Skip to content

fix saving versions on windows #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 19, 2025
Merged

fix saving versions on windows #8792

merged 10 commits into from
Feb 19, 2025

Conversation

@bjarzemb
Copy link
Contributor

@bjarzemb bjarzemb commented Dec 9, 2024 •
edited
Loading

Before:

>python -c "import torchvision; print(torchvision.__version__)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'torchvision' has no attribute '__version__'

After:

>python -c "import torchvision; print(torchvision.__version__)"
0.20.0a0+6279faa

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8792

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @bjarzemb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

NicolasHug
NicolasHug reviewed Dec 9, 2024
View reviewed changes
@bjarzemb @NicolasHug
Update setup.py
33ee3d7 
Co-authored-by: Nicolas Hug <[email protected]>
NicolasHug
NicolasHug approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjarzemb

@NicolasHug
Copy link
Member

@bjarzemb please make sure to sign the CLA so I can merge this PR :) !
code.facebook.com/cla

@bjarzemb
Copy link
Contributor Author

@NicolasHug CLA signed. Thanks!

@bjarzemb
Copy link
Contributor Author

@NicolasHug can you take a look at this PR? :)

@bjarzemb
Copy link
Contributor Author

@NicolasHug Can you help with merging this PR?

@bjarzemb
Copy link
Contributor Author

bjarzemb commented Feb 6, 2025

@atalman Can you help me to merge this PR?

@NicolasHug
Copy link
Member

I will eventually, but pinging won't help

@NicolasHug
Copy link
Member

Merging, thanks for your patience @bjarzemb

@NicolasHug NicolasHug merged commit 1604a18 into pytorch:main Feb 19, 2025
1 check passed
facebook-github-bot pushed a commit that referenced this pull request Jul 9, 2025
@NicolasHug @facebook-github-bot
[fbsync] fix saving versions on windows (#8792)
d1fb549 
Reviewed By: scotts

Differential Revision: D77997076

fbshipit-source-id: faa97c533a08ce070cbac4a76b5e0e00c3f5cd8a

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Nicolas Hug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed enhancement topic: build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjarzemb @facebook-github-bot @NicolasHug